Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #5918: PHP Fatal error debugging #6279

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Nov 21, 2023

Description

Depending on the Log librairie version, the path is different. As within WP Rocket we were loading it from one path, it could result into a fatal error.

Fixes #5918

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

@Miraeld Miraeld added type: bug Indicates an unexpected problem or unintended behavior module: Logger labels Nov 21, 2023
@Miraeld Miraeld requested a review from a team November 21, 2023 06:10
@Miraeld Miraeld self-assigned this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: Logger type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP fatal error with PHP 8.1, repo / Composer installation and WP Rocket's debugging enabled
2 participants