Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix relative urls regex in cdn to work with dots #6195

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mostafa-hisham
Copy link
Contributor

@mostafa-hisham mostafa-hisham commented Sep 28, 2023

Description

fix relative urls regex in cdn to work with dots

Fixes #3724

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

@mostafa-hisham mostafa-hisham marked this pull request as ready for review September 28, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDN isnot applied on images with relative url containing query string
1 participant