Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #146: Adds headless config #147

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Sep 19, 2024

Description

Fixes #146
This PR makes the end-to-end (e2e) tests compatible with headless mode, allowing them to be run within a Docker container. This ensures a consistent testing environment for all team members, regardless of their local setup.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

To trigger the new code, set the ENV_HEADLESS environment variable to 'true' when running the e2e tests. This will launch the Chromium browser in headless mode.

Technical description

Documentation

The changes in this PR involve adding a new ENV_HEADLESS environment variable and updating the Chromium launch configuration to use this variable. If ENV_HEADLESS is 'true', the Chromium browser is launched in headless mode. This is often used in automated testing environments.

Don't forget to modify you config file

New dependencies

No new dependencies are required for this change.

Risks

There are no known performance or security risks associated with this change.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@Miraeld Miraeld added the enhancement New feature or request label Sep 19, 2024
@Miraeld Miraeld requested review from Khadreal, jeawhanlee and a team September 19, 2024 04:30
@Miraeld Miraeld self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make e2e compatible with headless
1 participant