Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #129 Automate the scenario that check LL isnot applied on LCP/ATF images #144

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Sep 18, 2024

Description

Fixes #129

Type of change

  • New feature (non-breaking change which adds functionality).
  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Check #129

Technical description

Add new steps for imagify process

Documentation

Allow QA to automate test for atf/lcp when LL is enabled

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@Miraeld Miraeld changed the title WIP: LL Not applied to LCP DRAFT: LL Not applied to LCP Sep 18, 2024
@Khadreal Khadreal changed the title DRAFT: LL Not applied to LCP Closes #129 Automate the scenario that check LL isnot applied on LCP/ATF images Sep 23, 2024
@Khadreal Khadreal requested a review from a team September 23, 2024 16:08
src/features/ll-lcp.feature Outdated Show resolved Hide resolved
src/support/steps/general.ts Outdated Show resolved Hide resolved
src/support/steps/general.ts Outdated Show resolved Hide resolved
src/support/steps/imagify.ts Outdated Show resolved Hide resolved
utils/commands.ts Show resolved Hide resolved
@MathieuLamiot MathieuLamiot requested a review from a team October 2, 2024 10:06
@hanna-meda
Copy link
Contributor

@Khadreal @jeawhanlee cc @Miraeld, for me @lcpll tests on PR #144 still fail, with error in debug.log

PHP Fatal error:  Uncaught Error: Call to undefined function undefined() in /var/www/html/hanna.e2e.rocketlabsqa.ovh/wp-content/rocket-test-data/templates/triggerErrorInDebug.php:6
Stack trace:
#0 /var/www/html/hanna.e2e.rocketlabsqa.ovh/wp-includes/template-loader.php(106): include()
#1 /var/www/html/hanna.e2e.rocketlabsqa.ovh/wp-blog-header.php(19): require_once('...')
#2 /var/www/html/hanna.e2e.rocketlabsqa.ovh/index.php(17): require('...')
#3 {main}
  thrown in /var/www/html/hanna.e2e.rocketlabsqa.ovh/wp-content/rocket-test-data/templates/triggerErrorInDebug.php on line 6

And the e2e rocket helper plugin I think needs to be updated with new hook name:
PHP Deprecated: Hook rocket_lcp_delay is deprecated since version 3.16.4! Use rocket_performance_hints_optimization_delay instead. in /var/www/html/hanna.e2e.rocketlabsqa.ovh/wp-includes/functions.php on line 6078
and even though scenarios with Imagify are expected to fail due to Imagify issue, the 1 scenario at least should be expected to pass, but it fails. Sharing my results below, if one of you can help me debug. Thanks.

tests_results_lcpll_on_PR144.txt
cucumber-report-html-2024-10-03-16_08_23.pdf
video: da516a9a1894b1fa7cca3489cd808cb0.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCP: As QA I want to automate the scenario that check LL isnot applied on LCP/ATF images
4 participants