Escape values to avoid breaking them within single quotes #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
force-pushed
the
93-escape-config-values
branch
2 times, most recently
from
7980bad to
296937c
Compare
schlessera
force-pushed
the
93-escape-config-values
branch
from
296937c to
44abadc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the values provided through the user's arguments are printed within single quotes in the
wp-config.phpfile's defines, we need to escape them properly to avoid breaking these single quoted strings.This is a stop-gap measure to fix the bug reported in #93, but the proper solution would be to rewrite according to #94 and centralize all validation and escaping in
wp-cli/wp-config-transformer.Fixes #93