feat(agreement): change to manage agreements dynamically #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woowahan-neo
approved these changes
May 9, 2024
| create table agreement | ||
| ( | ||
| id bigint not null auto_increment, | ||
| content varchar(5000) not null, |
There was a problem hiding this comment.
a: 만약 5000 넘어갈 일이 있다면 있을 것 같으면 미리 TEXT로 만들어둬도 좋겠네요
There was a problem hiding this comment.
#738 (comment) 에서 실제로 사용되는 동의서는 636자, 1,180바이트이네요. 1,000자를 넘을 가능성은 거의 없어 보이지만, 레코드가 약 8,000바이트 정도를 넘어야 길이가 긴 컬럼을 off-page에 저장한다고 하니 지금은 걱정하지 않아도 될 것 같아요.
woowabrie
approved these changes
May 16, 2024
| import io.kotest.matchers.shouldBe | ||
| import io.kotest.matchers.string.shouldContain | ||
|
|
||
| class IndentTest : StringSpec({ |
| @@ -92,7 +103,7 @@ const Header = () => { | |||
| <> | |||
| <Link to={PATH.LOGIN}>로그인</Link> | |||
| <div className={styles.bar} /> | |||
| <Link to={PATH.SIGN_UP}>회원가입</Link> | |||
| <a onClick={goToSignUp}>회원가입</a> | |||
There was a problem hiding this comment.
c: href 없는 a tag로 바꾸면서 cursor가 pointer가 아닌 text 가 되었네요.
css 설정을 하거나 href="#" 넣고 이벤트를 막는 처리가 들어가면 좋을 것 같습니다! (어떤게 정석이죠?ㅋㅋ)
There was a problem hiding this comment.
오! 좋습니다. 제가 놓친 부분이에요 ㅎㅎ
여러 부분 고민했는데 Link에도 href="#"를 넣고 사용할 수 있네요 ㅎㅎ
확인해 보니 브라우저 접근성 측면에서도 href="#" 처리가 좀 더 나아 보입니다!
일관성을 맞추기 위해서 이 부분 코드 수정해서 반영해둘게요!
woowahan-cron
force-pushed
the
feature/agreement
branch
from
4e99c24
to
366067a
Compare
|
@woowabrie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #738
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?
어떤 부분에 집중하여 리뷰해야 할까요?
참고 자료
RCA 룰
r: 꼭 반영해 주세요. 적극적으로 고려해 주세요. (Request changes)
c: 웬만하면 반영해 주세요. (Comment)
a: 반영해도 좋고 넘어가도 좋습니다. 그냥 사소한 의견입니다. (Approve)