Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run wc_update_900_add_launch_your_store_tour_option on WC 9.0 update #47634

Merged
merged 4 commits into from
May 21, 2024

Conversation

moon0326
Copy link
Contributor

@moon0326 moon0326 commented May 20, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #47603 .

This PR adds a new update function to add woocommerce_show_lys_tour option on WC 9.0 update.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create an empty JN site.
  2. Install WC 8.9.0
  3. Checkout this branch locally and build a zip by running pnpm run build:zip in plugins/woocommerce directory.
  4. Upload the zip and activate WooCommerce.
  5. Confirm woocommerce_show_lys_tour option exist.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • [] Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Add a new update function for WC 9.0 to add woocommerce_show_lys_tour option.

Comment

@moon0326 moon0326 requested review from a team, ilyasfoo and adrianduffell May 20, 2024 18:16
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 20, 2024
Copy link
Contributor

Hi @ilyasfoo, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented May 20, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@moon0326 moon0326 closed this May 21, 2024
@moon0326 moon0326 reopened this May 21, 2024
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, I can see the tour show up after database update. 🚢

I triggered the release action to build the zip file. Here is the link to the zip file: https://github.com/woocommerce/woocommerce/actions/runs/9168212331/artifacts/1521362326

Confirm woocommerce_show_lys_tour option does not exist.

I believe the woocommerce_show_lys_tour option should exist. 😄

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment! 🚢

* Add woocommerce_show_lys_tour.
*/
function wc_update_900_add_launch_your_store_tour_option() {
update_option( 'woocommerce_show_lys_tour', 'yes' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of using add_option instead? This can help to make it safer by setting the option only when it doesn't exist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilyasfoo Good idea! Updated in Use add_option

@moon0326
Copy link
Contributor Author

I believe the woocommerce_show_lys_tour option should exist. 😄

Good catch 😄 Updated!

@moon0326 moon0326 merged commit 363d761 into trunk May 21, 2024
23 checks passed
@moon0326 moon0326 deleted the update/apply-coming-soon-mode-db-update-for-9 branch May 21, 2024 19:15
@github-actions github-actions bot added this to the 9.0.0 milestone May 21, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 21, 2024
@Stojdza Stojdza added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply coming soon mode db update for 9.0 version
4 participants