Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-jobs] Add disableHpos test environment variable #47619

Merged
merged 21 commits into from
May 21, 2024

Conversation

adimoldovan
Copy link
Contributor

@adimoldovan adimoldovan commented May 20, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR fixes 2 problems:

  1. The DISABLE_HPOS env variable is not set in CI and the disabling of the feature was not happening in the test environment setup script.
  2. Even with the above fixed, if the setup script disables the feature, after the first login the feature is reset to the default.

The fix:

  1. Properly set the environment variable via the ci-jobs utility.
  2. Toggle the feature via the global setup after the first login.

I replaced the global setup logic of enabling the feature (ENABLE_HPOS) with disabling it (DISABLE_HPOS) as it makes more sense to me to be explicit about the action that changes the default state.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Tested with this run where the HPOS disabled tests were set to run on pull_request. The DISABLE_HPOS=1 is correctly set in the env, and the global setup disables the feature.

@adimoldovan adimoldovan changed the title Add disableHpos test env variable [ci-jobs] Add disableHpos test environment variable May 20, 2024
@adimoldovan adimoldovan self-assigned this May 20, 2024
@github-actions github-actions bot added focus: monorepo infrastructure Issues and PRs related to monorepo tooling. plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 20, 2024
Copy link
Contributor

github-actions bot commented May 20, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@github-actions github-actions bot added the focus: e2e tests Issues related to e2e tests label May 20, 2024
@github-actions github-actions bot added focus: api tests Issues related to API tests. focus: performance tests The issue/PR is release to performance testing. labels May 21, 2024
@adimoldovan adimoldovan marked this pull request as ready for review May 21, 2024 08:56
@woocommercebot woocommercebot requested a review from a team May 21, 2024 08:58
Copy link
Contributor

Hi , @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@rrennick rrennick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@rrennick rrennick merged commit cf6e01d into trunk May 21, 2024
29 checks passed
@rrennick rrennick deleted the ci/add-disableHpos-env-varible branch May 21, 2024 21:33
@github-actions github-actions bot added this to the 9.0.0 milestone May 21, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 21, 2024
@Stojdza Stojdza added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: api tests Issues related to API tests. focus: e2e tests Issues related to e2e tests focus: monorepo infrastructure Issues and PRs related to monorepo tooling. focus: performance tests The issue/PR is release to performance testing. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants