-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci-jobs] Add disableHpos test environment variable #47619
Conversation
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
…d-disableHpos-env-varible
Hi , @woocommerce/vortex Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR fixes 2 problems:
The fix:
I replaced the global setup logic of enabling the feature (ENABLE_HPOS) with disabling it (DISABLE_HPOS) as it makes more sense to me to be explicit about the action that changes the default state.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Tested with this run where the HPOS disabled tests were set to run on
pull_request
. TheDISABLE_HPOS=1
is correctly set in the env, and the global setup disables the feature.