Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DON'T MERGE YET] Rename Google Listings and Ads with Google for WooCommerce #47614

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from

Conversation

puntope
Copy link
Contributor

@puntope puntope commented May 20, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

PT: pcTzPl-2i9-p2

This PR replaces all the "Google Listings and Ads" occurrences with "Google for WooCommerce"

How to test the changes in this Pull Request:

  1. Verify in Codebase that there are no instances left of Google Listings and Ads or Google Listings & Ads.
  2. Checks (PHP Unit and JS tests) are passing.
  3. Check the changes in this PR to see if they make sense.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Rename Google Listings and Ads with Google for WooCommerce

Comment

@puntope puntope self-assigned this May 20, 2024
@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests focus: monorepo infrastructure Issues and PRs related to monorepo tooling. package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 20, 2024
puntope and others added 2 commits May 20, 2024 15:45
…ommerce/data, packages/php/remote-specs-validation, woocommerce
Copy link
Contributor

github-actions bot commented May 20, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@puntope puntope requested a review from a team May 20, 2024 11:54
Copy link
Contributor

Hi , @woocommerce/automata

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@puntope puntope changed the title Rename Google Listings and Ads with Google for WooCommerce [Don't merge yet] Rename Google Listings and Ads with Google for WooCommerce May 20, 2024
@puntope puntope changed the title [Don't merge yet] Rename Google Listings and Ads with Google for WooCommerce [DON'T MERGE YET] Rename Google Listings and Ads with Google for WooCommerce May 20, 2024
@puntope puntope requested review from a team and removed request for a team May 22, 2024 08:42
Copy link

@ianlin ianlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebranding to Google for WooCommerce. All good but just found there's still one place missing: ./plugins/woocommerce-admin/client/marketing/components/CreateNewCampaignModal/CreateNewCampaignModal.test.tsx

@puntope
Copy link
Contributor Author

puntope commented May 31, 2024

Thanks for rebranding to Google for WooCommerce. All good but just found there's still one place missing: ./plugins/woocommerce-admin/client/marketing/components/CreateNewCampaignModal/CreateNewCampaignModal.test.tsx

Thanks for catching that one @ianlin

Its fixed, can you take another look?

Copy link

@ianlin ianlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests focus: monorepo infrastructure Issues and PRs related to monorepo tooling. package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants