[testing workflows] Add workflow_call trigger in CI workflow - support daily and other types of runs #47612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
focus: monorepo infrastructure
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
github-actions
bot
added
the
plugin: woocommerce
…d-workflow-call-event # Conflicts: # plugins/woocommerce/package.json # tools/monorepo-utils/dist/index.js
adimoldovan
changed the title
github-actions
bot
added
package: @woocommerce/components
adimoldovan
changed the title
…d-workflow-call-event
|
Hi , @woocommerce/vortex Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
lanej0
approved these changes
May 22, 2024
| use: { ...devices[ 'Desktop Chrome' ] }, | ||
| testIgnore: | ||
| /.*smoke-tests\/*|.*js-file-monitor\/*|.*admin-tasks\/*|.*activate-and-setup\/*|.*admin-analytics\/*|.*admin-marketing\/*/, | ||
| }, |
There was a problem hiding this comment.
Nice use of projects here. Think this'll be a great way to segment the different types of tests we need to run.
github-actions
bot
added
the
needs: analysis
Stojdza
added
status: analysis complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Prep work for #47532
Adds the
workflow_calltrigger forci.yml. This makes it possible to trigger the jobs defined inci.ymlby other events.Instead of defining all the possible triggers in ci.yml directly, I think it would be cleaner to have other workflows that are triggered by those events (e.g. cron) and have those workflows call
ci.ymlwith specific inputs (e.g.daily-e2e,release-checks, etc.).This PR adds the
tests-daily-run.ymlworkflow which will run on a schedule and callci.ymlwith thedaily-e2einput. Theci-jobsutility will return a jobs matrix with only those jobs configured to run ondaily-e2eevent - currently onlyCore e2e tests - Gutenberg.I only configured the Gutenberg job as an example and to test it. All other daily or release test projects will be configured in follow-up PRs and
smoke-test-daily.ymlandsmoke-test-release.ymlwill be deprecated.I had to update the events for all test jobs in all projects files so that they will not run on daily runs. I did not update the lint jobs because they are restricted at workflow level since #47652.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
workflow_callevent bytests-daily-run.ymlwithinputs.trigger=daily-e2e. Only the e2e tests with Gutenberg ran (ignore the lint jobs, they will not run once [ci] Only run lint jobs on pull_request event #47652 is merged). The tests are expected to fail, you can ignore the results.