Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fluttium_interfaces): refactor to use addons semantics instead of actions #204

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(fluttium_interfaces): refactor to use addons semantics instead of actions #204

wants to merge 5 commits into from

Conversation

wolfenrain
Copy link
Owner

@wolfenrain wolfenrain commented Mar 11, 2023 •
edited
Loading

Status

READY

Description

Refactor to addons semantics instead of actions, part of #197

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@wolfenrain wolfenrain changed the title feat(fluttium_interfaces): refactor to use addons semantics instead o… feat(fluttium_interfaces): refactor to use addons semantics instead of actions Mar 11, 2023
@renancaraujo
Copy link
Collaborator

Looking good

felangel
felangel reviewed Mar 26, 2023
View reviewed changes
Copy link
Collaborator

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit but technically isn’t it “add-on” which would mean in Dart it should be addOn or addOns?

@wolfenrain
Copy link
Owner Author

wolfenrain commented Mar 27, 2023 •
edited
Loading

Nit but technically isn’t it “add-on” which would mean in Dart it should be addOn or addOns?

Oh. Well dang, now I have to rethink the wording because I dont like addOns or add_ons for the fluttium.yaml

After careful consideration I have decided to keep it as addons as that is acceptable within the context (according to wikipedia)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel left review comments

@renancaraujo renancaraujo renancaraujo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wolfenrain @renancaraujo @felangel