Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDK5 sample project #18

Closed
wants to merge 9 commits into from
Closed

MDK5 sample project #18

wants to merge 9 commits into from

Conversation

kojo1
Copy link

@kojo1 kojo1 commented May 27, 2018

with wrap_test.c

@dgarske dgarske self-assigned this May 30, 2018
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this example. Just a few minor things. David

IDE/MDK5/dummy.c Outdated
(void)userCtx;
return 0;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1335, USA
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this to match the other wolfTPM license headers (2018 and wolfTPM).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can you make sure WOLF_CRYPTO_DEV is added in here to support the wolfCrypt callbacks?

@dgarske dgarske assigned kojo1 and unassigned dgarske May 30, 2018
@dgarske
Copy link
Contributor

dgarske commented Jun 6, 2018

Hi @kojo1 : Can you resolve the merge conflict (rebase). Also this needs the include.am added. Thanks!

@kojo1
Copy link
Author

kojo1 commented Jun 9, 2018

UART4 is changed to USART1, just it does not seem to be defined with some STM32F4

dgarske added a commit to dgarske/wolfTPM that referenced this pull request Jun 11, 2018
@dgarske
Copy link
Contributor

dgarske commented Jul 19, 2018

Replaced with PR #22.

@dgarske dgarske closed this Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants