add update for socat 1.8.0.0 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobBarthelmeh
assigned JacobBarthelmeh and julek-wolfssl and unassigned JacobBarthelmeh
julek-wolfssl
requested changes
Jun 10, 2024
socat/1.8.0.0/socat-1.8.0.0.patch
Outdated
Comment on lines
1822
to
1826
| + #if defined(WITH_WOLFSSL) && defined(WOLFSSL_TLS13) | ||
| + /* Can't use sycSSLv23_client_method because wolfSSL will default to | ||
| + * TLS 1.3, which doesn't work with socat." */ | ||
| + method = sycTLSv1_2_client_method(); | ||
| + #else |
There was a problem hiding this comment.
sycSSLv23_client_method allows downgrading. It would be better to use sycSSLv23_client_method and then set the max proto later once the ctx is created.
JacobBarthelmeh
assigned julek-wolfssl and JacobBarthelmeh and unassigned JacobBarthelmeh and julek-wolfssl
julek-wolfssl
requested changes
Jun 13, 2024
socat/1.8.0.0/socat-1.8.0.0.patch
Outdated
Comment on lines
1821
to
1822
| - method = sycSSLv23_client_method(); | ||
| + method = sycSSLv23_client_method(); |
There was a problem hiding this comment.
Please remove from the patch.
socat/1.8.0.0/socat-1.8.0.0.patch
Outdated
Comment on lines
1842
to
1843
| - method = sycSSLv23_server_method(); | ||
| + method = sycSSLv23_server_method(); |
julek-wolfssl
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on wolfSSL/wolfssl#7594