Add mosquitto OSP #145
Merged
Add mosquitto OSP #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kareem-wolfssl
requested changes
May 31, 2023
embhorn
force-pushed
the
mosquitto-port
branch
2 times, most recently
from
5d9c535
to
632efa8
Compare
kareem-wolfssl
previously requested changes
Jun 2, 2023
There was a problem hiding this comment.
Code looks good to me.
Seeing some test failures as we discussed on Slack. Since some tests are also failing with OpenSSL, the patch file/README should clarify that some tests are expected to fail (and ideally which)
Would be great to fix the unique wolfSSL test failures if possible.
|
It would be nice to add a github action for this OSP to wolfMQTT. |
|
How would that work exactly? We already test wolfMQTT against Mosquitto (built with OpenSSL). |
|
You're right. Mosquitto is being linked against wolfSSL so it should be tested in the wolfSSL PRB tests. |
julek-wolfssl
requested changes
Jun 7, 2024
julek-wolfssl
approved these changes
Jun 10, 2024
|
Tabs-to-spaces from my editor messed up the patch file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds wolfSSL support to Mosquitto 2.0.18
See README.md for build instructions