Unix domain socket support #408
Merged
+106
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to connect via Unix Domain Sockets by introducing the `useUnixSocket` flag. Adjusted connection logic to handle `unix://` host prefixes and updated the dialing mechanism to use the appropriate network type (`unix` or `tcp`). This enhances flexibility in connection methods.
This commit introduces functionality to handle Unix domain socket (UDS) connections. It includes updates to the client and test suite to validate UDS support and extends the test server to support Unix sockets. These changes ensure compatibility for environments requiring UDS communication.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
==========================================
+ Coverage 94.67% 94.69% +0.01%
==========================================
Files 30 30
Lines 3515 3526 +11
==========================================
+ Hits 3328 3339 +11
Misses 138 138
Partials 49 49 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for connecting to a Unix Domain Socket instead of a TCP port.
The
Clientcan be intructed to connect to a unix socket by prefixing the host withunix://(Example:mail.NewClient("unix:///var/spool/postfix/private/smtpunix")This feature is requested by the Forgejo project as part of a possible migration to go-mail: https://codeberg.org/forgejo/forgejo/issues/6028#issuecomment-2560355