finish getItemValue/Label deprecation #3076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adids1221 I see many usages to 'getItemLabel'... Is it not deprecated as well? Also on picker.types file there is a mention in the 'value' prop comment to 'getItemValue' |
|
@Inbal-Tish I rephrased the |
adids1221
deleted the
infra/Picker_refactor_getItemValue_Label_prop_deprecation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picker refactor -
getItemValue & getItemLabelfinish props deprecation.Picker.Item
getItemLabelprop is now "independent" type inPickerItemProps.Changelog
Picker
getItemValue & getItemLabelfinish props deprecation.Additional info
MADS - 4178