feat(vercel): allow external redirects #404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6c06aba The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
reviewed
Nov 19, 2024
| @@ -18,6 +18,7 @@ describe('Redirects', () => { | |||
| }, | |||
| '/blog/[...slug]': '/team/articles/[...slug]', | |||
| '/Basic/http-2-0.html': '/posts/http2', | |||
| '/google': 'https://google.com', | |||
There was a problem hiding this comment.
Astro doesn't support external redirects, so adding on here is misleading because it won't work with other adapters.
Since you're adding the feature for the Vercel adapter, what about adding a new option to the adapter, maybe called externalRedirects?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was originally opened on the main Astro repo: withastro/astro#11422
Changes
Before:
Redirects with schema defined in astro.config.mjs were converted into paths on the same site: https://google.com -> /https://google.com
After:
External redirects are detected and don't have the project base path prepended.
Testing
The output (esp.
.vercel/output/config.json) of building a project with the updated integration was manually inspected.A test was added
Docs
The Astro docs generally state that supporting external links configured through
astro.config.mjsisn't a goal. While the Cloudflare adapter already supports external redirects, the Vercel adapter handled external redirects differently so far. Therefore this could potentially be considered a breaking change.