Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the tests to use WireMock 3.0.0 release #72

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update the tests to use WireMock 3.0.0 release #72

wants to merge 6 commits into from

Conversation

oleg-nenashev
Copy link
Member

References

  • TODO

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@oleg-nenashev oleg-nenashev mentioned this pull request Aug 30, 2023
Closed
oleg-nenashev
oleg-nenashev commented Aug 31, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@oleg-nenashev oleg-nenashev marked this pull request as ready for review August 31, 2023 15:57
@oleg-nenashev oleg-nenashev added the chore Maintenance label Aug 31, 2023
oleg-nenashev
oleg-nenashev commented Aug 31, 2023
View reviewed changes
Copy link
Member Author

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should stop hardcoding JAR versions...

...ava/org/wiremock/integrations/testcontainers/WireMockContainerExtensionsCombinationTest.java Outdated Show resolved Hide resolved
...st/java/org/wiremock/integrations/testcontainers/WireMockContainerExtensionsWebhookTest.java Outdated Show resolved Hide resolved
bitxon
bitxon reviewed Sep 25, 2023
View reviewed changes
src/main/java/org/wiremock/integrations/testcontainers/WireMockContainer.java
/**
* @deprecated Not really guaranteed to be latest. Will be reworked
*/
@Deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove it, since we haven't yet released - we could afford removing old code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitxon bitxon bitxon approved these changes

Assignees
No one assigned
Labels
chore Maintenance
Projects
None yet
Milestone
wiremock-testcontainers-1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oleg-nenashev @bitxon