-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode): rename refactor #6461
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-6461.fly.dev 🚀 Last Updated (UTC) 2024-05-13 18:45 |
Signed-off-by: monada-bot[bot] <[email protected]>
BenchmarksComparison to Baseline 🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-05-12 13:23 |
Please include a detailed description with any important implementation notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM great job!
Thanks for contributing, @tsuf239! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.73.46. |
Checklist
fixes: #4596
https://www.loom.com/share/234a65f04ecb471b84621aa0cf27f66c
Created a new
rename_visitor
that has a list of symbol declarations and the references to them. it adds a symbol either as a reference or as a declaration during the visit.when executing
create_text_edits
it chooses the symbol declaration and references the position belongs to and creates textEdits with the new_text passed by the LSP.I also updated the
get_ranges
method to get all ranges in a certain line (and not only the first one)Currently, the renaming of class properties and namespaces is unsupported:
namespaces need a "customized" edit:
bring ex;
withexternals
as the new word won't becomebring externals;
butbring ex as externals;
.it seems like properties aren't declared/defined as the other symbols- so the current procedure isn't working for them.
Title matches Winglang's style guide
Description explains motivation and solution
Tests added (always)
Docs updated (only required for features)
Added
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.