Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): improve name of queue consumer handler #6456

Merged
merged 4 commits into from
May 14, 2024
Merged

Conversation

eladb
Copy link
Contributor

@eladb eladb commented May 12, 2024

Rename the name of the implicit cloud.Function created when adding a consumer to a cloud.Queue from SetConsumerXX to ConsumerXX.

image

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

The previous name was `SetConsumerXX` which doesn't make sense semantically.

Rename to `ConsumerXX` instead.
@eladb eladb requested a review from a team as a code owner May 12, 2024 07:09
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented May 12, 2024

Console preview environment is available at https://wing-console-pr-6456.fly.dev 🚀

Last Updated (UTC) 2024-05-14 22:53

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label May 13, 2024
@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label May 14, 2024
Copy link
Contributor

mergify bot commented May 14, 2024

Thanks for contributing, @eladb! This PR will now be added to the merge queue, or immediately merged if eladb-patch-6 is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit cbabb1f into main May 14, 2024
15 checks passed
@mergify mergify bot deleted the eladb-patch-6 branch May 14, 2024 22:59
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.73.44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants