-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compiler)!: explicit lift qualification statement #6400
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-6400.fly.dev 🚀 Last Updated (UTC) 2024-05-19 09:18 |
BenchmarksComparison to Baseline 🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-05-19 09:24 |
Signed-off-by: monada-bot[bot] <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
…ang/wing into yoav/explicit_lift_qual_v2
Signed-off-by: monada-bot[bot] <[email protected]>
…ang/wing into yoav/explicit_lift_qual_v2
Signed-off-by: monada-bot[bot] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work @yoav-steinberg! Added a few suggestions but otherwise looks good to me.
Co-authored-by: Chris Rybicki <[email protected]>
Co-authored-by: Chris Rybicki <[email protected]>
Co-authored-by: Chris Rybicki <[email protected]>
Co-authored-by: Chris Rybicki <[email protected]>
Co-authored-by: Chris Rybicki <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
Thanks for contributing, @yoav-steinberg! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.74.0. |
fixes #6080
Initial implementation of the explicit lift statement as defined in the rfc.
Breaking change: this is instead of the
lift()
builtin macro that was used for the same purpose.Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.