Strict compare

src/Application/AbstractWebApplication.php

@@ -205,7 +205,7 @@ public function redirect($url, $code = 303)
 			$prefix = $uri->toString(['scheme', 'user', 'pass', 'host', 'port']);
 
 			// We just need the prefix since we have a path relative to the root.
-			if ($url[0] == '/')
+			if ($url[0] === '/')
 			{
 				$url = $prefix . $url;
 			}

src/Authentication/Test/Mock/MockMethod.php

@@ -28,9 +28,9 @@ class MockMethod extends AbstractMethod
 	 */
 	public function authenticate(Credential $credential)
 	{
-		if ($credential->username == 'flower')
+		if ($credential->username === 'flower')
 		{
-			if ($credential->password == '1234')
+			if ($credential->password === '1234')
 			{
 				$this->status = Authentication::SUCCESS;
 

src/Cache/Storage/RedisStorage.php

@@ -160,7 +160,7 @@ protected function connect()
 			return $this;
 		}
 
-		if (($this->defaultHost == 'localhost' || filter_var($this->defaultHost, FILTER_VALIDATE_IP)))
+		if (($this->defaultHost === 'localhost' || filter_var($this->defaultHost, FILTER_VALIDATE_IP)))
 		{
 			$this->driver->connect('tcp://' . $this->defaultHost . ':' . $this->defaultPort, $this->defaultPort);
 		}

src/Compare/Compare.php

@@ -217,7 +217,7 @@ public function setOperator($operator)
 	 */
 	public function quote($string, $quote = "''")
 	{
-		if (!$quote && $quote != '0')
+		if (!$quote && (string) $quote !== '0')
 		{
 			return $string;
 		}

src/Console/Command/RootCommand.php

@@ -84,7 +84,7 @@ protected function prepareExecute()
 			throw new \Exception('RootCommand::$app should have Console Application');
 		}
 
-		if (!$this->getOption('ansi') || strtolower($this->getOption('ansi')) == 'off')
+		if (!$this->getOption('ansi') || strtolower($this->getOption('ansi')) === 'off')
 		{
 			$this->console->set('ansi', false);
 

src/Data/Test/DataSetTest.php

@@ -393,7 +393,7 @@ public function testFilter()
 		{
 			$keys[] = $key;
 
-			return $data->flower == 'sakura';
+			return $data->flower === 'sakura';
 		});
 
 		$this->assertEquals(['sakura'], $new->flower);

src/DataMapper/README.md

@@ -393,7 +393,7 @@ This will generate where conditions like below:
 
 ``` sql
 WHERE `id` >= '5'
-    AND `name` != 'bar'
+    AND `name` !== 'bar'
     AND `published` < '1'
     AND `catid` NOT IN (1,2,3,4,5)
 ```

src/Database/Command/AbstractWriter.php

@@ -184,7 +184,7 @@ public function updateOne($table, $data, $key, $updateNulls = false)
 			}
 
 			// Only process scalars that are not internal fields.
-			if (is_array($v) || is_object($v) || $k[0] == '_')
+			if (is_array($v) || is_object($v) || $k[0] === '_')
 			{
 				continue;
 			}

src/Database/Driver/AbstractDatabaseDriver.php

@@ -566,7 +566,7 @@ public function replacePrefix($sql, $prefix = '#__')
 
 				$l = $k - 1;
 
-				while ($l >= 0 && $sql{$l} == '\\')
+				while ($l >= 0 && $sql{$l} === '\\')
 				{
 					$l--;
 					$escaped = !$escaped;
@@ -620,11 +620,11 @@ public static function splitSql($sql)
 		{
 			$current = substr($sql, $i, 1);
 
-			if (($current == '"' || $current == '\''))
+			if (($current === '"' || $current === '\''))
 			{
 				$n = 2;
 
-				while (substr($sql, $i - $n + 1, 1) == '\\' && $n < $i)
+				while (substr($sql, $i - $n + 1, 1) === '\\' && $n < $i)
 				{
 					$n++;
 				}
@@ -647,7 +647,7 @@ public static function splitSql($sql)
 				}
 			}
 
-			if (($current == ';' && !$open) || $i == $end - 1)
+			if (($current === ';' && !$open) || $i == $end - 1)
 			{
 				$queries[] = substr($sql, $start, ($i - $start + 1));
 				$start = $i + 1;
@@ -699,12 +699,12 @@ public function setQuery($query)
 	 */
 	public function loadAll($key = null, $class = '\\stdClass')
 	{
-		if (strtolower($class) == 'array')
+		if (strtolower($class) === 'array')
 		{
 			return $this->getReader()->loadArrayList($key);
 		}
 
-		if (strtolower($class) == 'assoc')
+		if (strtolower($class) === 'assoc')
 		{
 			return $this->getReader()->loadAssocList($key);
 		}
@@ -721,12 +721,12 @@ public function loadAll($key = null, $class = '\\stdClass')
 	 */
 	public function loadOne($class = '\\stdClass')
 	{
-		if (strtolower($class) == 'array')
+		if (strtolower($class) === 'array')
 		{
 			return $this->getReader()->loadArray();
 		}
 
-		if (strtolower($class) == 'assoc')
+		if (strtolower($class) === 'assoc')
 		{
 			return $this->getReader()->loadAssoc();
 		}

src/Database/Driver/Pdo/PdoDriver.php

@@ -90,7 +90,7 @@ public function __construct(\PDO $connection = null, $options = [])
 		$options = array_merge($defaultOptions, $options);
 
 		// We shouldn't use pdo directly.
-		if ($this->name == 'pdo')
+		if ($this->name === 'pdo')
 		{
 			$this->name = $options['driver'];
 		}

src/Database/Query/QueryHelper.php

@@ -159,7 +159,7 @@ public function registerQueryTables(QueryInterface $query)
 	{
 		foreach ($this->tables as $alias => $table)
 		{
-			if ($table['join'] == 'FROM')
+			if ($table['join'] === 'FROM')
 			{
 				$query->from($query->quoteName($table['name']) . ' AS ' . $query->quoteName($alias));
 			}

src/Database/Test/AbstractDatabaseTestCase.php

@@ -137,7 +137,7 @@ public static function setUpBeforeClass()
 		$db->select($dbname);
 
 		// MySQL Strict Mode
-		if (static::$driver == 'mysql' && !empty(static::$dsn['strict_mode']))
+		if (static::$driver === 'mysql' && !empty(static::$dsn['strict_mode']))
 		{
 			$db->setQuery("SET sql_mode = 'NO_ENGINE_SUBSTITUTION,STRICT_ALL_TABLES'")->execute();
 		}

src/Environment/Browser/Browser.php

@@ -670,6 +670,6 @@ public function isRobot($refresh = false)
 	 */
 	public function isSSLConnection()
 	{
-		return (!empty($this->server['HTTPS']) && strtolower($this->server['HTTPS']) != 'off');
+		return (!empty($this->server['HTTPS']) && strtolower($this->server['HTTPS']) !== 'off');
 	}
 }

src/Environment/Platform.php

@@ -91,7 +91,7 @@ public function getOS()
 	 */
 	public function isWin()
 	{
-		return $this->getOS() == 'WIN';
+		return $this->getOS() === 'WIN';
 	}
 
 	/**
@@ -126,7 +126,7 @@ public function isUnix()
 	 */
 	public function isLinux()
 	{
-		return $this->getOS() == 'LIN';
+		return $this->getOS() === 'LIN';
 	}
 
 	/**

src/Environment/Test/PlatformTest.php

@@ -72,13 +72,13 @@ protected function setUp()
 		// Detect the native operating system type.
 		$this->os = strtoupper(substr(PHP_OS, 0, 3));
 
-		$this->isWin = $this->os == 'WIN';
+		$this->isWin = $this->os === 'WIN';
 
-		$this->isMac = $this->os == 'MAC';
+		$this->isMac = $this->os === 'MAC';
 
 		$this->isUnix = in_array($this->os, ['CYG', 'DAR', 'FRE', 'LIN', 'NET', 'OPE', 'MAC']);
 
-		$this->isLinux = $this->os == 'LIN';
+		$this->isLinux = $this->os === 'LIN';
 	}
 
 	/**

src/Event/README.md

@@ -65,7 +65,7 @@ Then we trigger the event we created:
 $dispatcher->triggerEvent($event);
 
 // ContentListener::onBeforeContentSave will set title into $content object.
-$content->title == 'My content';
+$content->title === 'My content';
 ```
 
 If a method name in listener equals to event name, Dispatcher will run this method and inject Event into this method.

src/Filesystem/Filesystem.php

@@ -150,7 +150,7 @@ public static function folders($path, $recursive = false, $toArray = false)
 
 				// If set to recursive, every returned folder name will include a dot (.),
 				// so we can't using isDot() to detect folder.
-				return $iterator->isDir() && ($iterator->getBasename() != '..');
+				return $iterator->isDir() && ($iterator->getBasename() !== '..');
 			}
 			else
 			{
@@ -193,7 +193,7 @@ public static function items($path, $recursive = false, $toArray = false)
 
 				// If set to recursive, every returned folder name will include a dot (.),
 				// so we can't using isDot() to detect folder.
-				return ($iterator->getBasename() != '..');
+				return ($iterator->getBasename() !== '..');
 			}
 			else
 			{

src/Filesystem/Path/PathLocator.php

@@ -235,20 +235,20 @@ protected function removeDots($path)
 		foreach ($path as $key => $row)
 		{
 			// Remove dot files
-			if ($row == '.')
+			if ($row === '.')
 			{
 				unset($path[$key]);
 			}
 
 			// Remove dots and go parent dir
-			if ($row == '..' && !$isBeginning)
+			if ($row === '..' && !$isBeginning)
 			{
 				unset($path[$key]);
 				unset($path[$key - 1]);
 			}
 
 			// Do not get parent if dots in the beginning
-			if ($row != '..' && $isBeginning)
+			if ($row !== '..' && $isBeginning)
 			{
 				$isBeginning = false;
 			}

src/Filesystem/Test/FilesystemTest.php

@@ -263,7 +263,7 @@ public function testFind()
 		// Callable condition
 		$condition = function ($current, $key, $iterator)
 		{
-			return pathinfo($current->getBasename(), PATHINFO_EXTENSION) == 'html';
+			return pathinfo($current->getBasename(), PATHINFO_EXTENSION) === 'html';
 		};
 
 		$files = Filesystem::find(static::$dest, $condition, true, true);
@@ -289,7 +289,7 @@ public function testFindByCallback()
 	{
 		$condition = function ($current, $key, $iterator)
 		{
-			return pathinfo($current->getBasename(), PATHINFO_EXTENSION) == 'html';
+			return pathinfo($current->getBasename(), PATHINFO_EXTENSION) === 'html';
 		};
 
 		$files = Filesystem::find(static::$dest, $condition, true, true);

src/Filter/HtmlCleaner.php

@@ -149,7 +149,7 @@ public static function isBadAttribute($attrSubSet)
 		$attrSubSet[1] = strtolower($attrSubSet[1]);
 
 		return (
-			((strpos($attrSubSet[1], 'expression') !== false) && ($attrSubSet[0]) == 'style')
+			((strpos($attrSubSet[1], 'expression') !== false) && ($attrSubSet[0]) === 'style')
 			|| (strpos($attrSubSet[1], 'javascript:') !== false)
 			|| (strpos($attrSubSet[1], 'behaviour:') !== false)
 			|| (strpos($attrSubSet[1], 'vbscript:') !== false)
@@ -253,7 +253,7 @@ protected function cleanTags($source)
 			$currentSpace = strpos($tagLeft, ' ');
 
 			// Are we an open tag or a close tag?
-			if (substr($currentTag, 0, 1) == '/')
+			if (substr($currentTag, 0, 1) === '/')
 			{
 				// Close Tag
 				$isCloseTag = true;
@@ -309,7 +309,7 @@ protected function cleanTags($source)
 				}
 
 				// Do we have an attribute to process? [check for equal sign]
-				if ($fromSpace != '/' && (($nextEqual && $nextSpace && $nextSpace < $nextEqual) || !$nextEqual))
+				if ($fromSpace !== '/' && (($nextEqual && $nextSpace && $nextSpace < $nextEqual) || !$nextEqual))
 				{
 					if (!$nextEqual)
 					{
@@ -343,14 +343,14 @@ protected function cleanTags($source)
 				else
 				// No more equal signs so add any extra text in the tag into the attribute array [eg. checked]
 				{
-					if ($fromSpace != '/')
+					if ($fromSpace !== '/')
 					{
 						$attr = substr($fromSpace, 0, $nextSpace);
 					}
 				}
 
 				// Last Attribute Pair
-				if (!$attr && $fromSpace != '/')
+				if (!$attr && $fromSpace !== '/')
 				{
 					$attr = $fromSpace;
 				}
@@ -404,7 +404,7 @@ protected function cleanTags($source)
 		}
 
 		// Append any code after the end of tags and return
-		if ($postTag != '<')
+		if ($postTag !== '<')
 		{
 			$preTag .= $postTag;
 		}
@@ -447,7 +447,7 @@ protected function cleanAttributes($attrSet)
 			// AND blacklisted attributes
 			if ((!preg_match('/[a-z]*$/i', $attrSubSet[0]))
 				|| (($this->xssAuto) && ((in_array(strtolower($attrSubSet[0]), $this->attrBlacklist))
-				|| (substr($attrSubSet[0], 0, 2) == 'on'))))
+				|| (substr($attrSubSet[0], 0, 2) === 'on'))))
 			{
 				continue;
 			}
@@ -558,7 +558,7 @@ protected function escapeAttributeValues($source)
 			// Figure out if we have a single or double quote and look for the matching closing quote
 			// Closing quote should be "/>, ">, "<space>, or " at the end of the string
 			$quote = substr($matches[0][0], -1);
-			$pregMatch = ($quote == '"') ? '#(\"\s*/\s*>|\"\s*>|\"\s+|\"$)#' : "#(\'\s*/\s*>|\'\s*>|\'\s+|\'$)#";
+			$pregMatch = ($quote === '"') ? '#(\"\s*/\s*>|\"\s*>|\"\s+|\"$)#' : "#(\'\s*/\s*>|\'\s*>|\'\s+|\'$)#";
 
 			// Get the portion after attribute value
 			if (preg_match($pregMatch, substr($remainder, $nextBefore), $matches, PREG_OFFSET_CAPTURE))

src/Filter/OutputFilter.php

@@ -36,7 +36,7 @@ public static function objectHTMLSafe(&$mixed, $quote_style = ENT_QUOTES, $exclu
 		{
 			foreach (get_object_vars($mixed) as $k => $v)
 			{
-				if (is_array($v) || is_object($v) || $v == null || substr($k, 1, 1) == '_')
+				if (is_array($v) || is_object($v) || $v == null || substr($k, 1, 1) === '_')
 				{
 					continue;
 				}

src/Form/Field/AbstractField.php

@@ -840,11 +840,11 @@ protected function handleXml(\SimpleXMLElement $xml)
 
 			$name = $parent->getName();
 
-			if ($name == 'fieldset')
+			if ($name === 'fieldset')
 			{
 				$this->fieldset = $this->fieldset ? : (string) $parent['name'];
 			}
-			elseif ($name == 'group')
+			elseif ($name === 'group')
 			{
 				array_unshift($group, (string) $parent['name']);
 			}

src/Form/Field/ListField.php

@@ -222,7 +222,7 @@ protected function handleOptions($xml, $options = [])
 		{
 			foreach ($xml->children() as $name => $option)
 			{
-				if ($option->getName() == 'optgroup')
+				if ($option->getName() === 'optgroup')
 				{
 					foreach ($option->children() as $opt)
 					{

src/Form/FormHelper.php

@@ -147,7 +147,7 @@ public static function setByPath(&$data, $paths, $value, $separator = '/', $type
 		 */
 		$createStore = function($type)
 		{
-			if (strtolower($type) == 'array')
+			if (strtolower($type) === 'array')
 			{
 				return [];
 			}

src/Http/Helper/ServerHelper.php

@@ -85,7 +85,7 @@ public static function getAllHeaders()
 
 		foreach ($_SERVER as $name => $value)
 		{
-			if (substr($name, 0, 5) == 'HTTP_')
+			if (substr($name, 0, 5) === 'HTTP_')
 			{
 				$headers[str_replace(' ', '-', ucwords(strtolower(str_replace('_', ' ', substr($name, 5)))))] = $value;
 			}