Clean up fundraising config calls #4846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T354575
Notes
This PR moves the API calls for the native form data (donate config and payment methods) from the Explore feed announcements content source to shortly before action sheet presentation. This should reduce the number of unnecessary API calls for most users, so that only those that intend to donate will make the call. This should also reduce the likelihood that we will hit the payment methods rate limit as we're testing.
I am also caching the responses for both calls for seven days, to match Android's implementation. We will lean on this cache if there is any issue with fetching.
Since there will now be a slight delay while we fetch the data, I also added a spinner in the Settings table view cell and the campaign modal donate button.
Test Steps