-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prettier #1687
base: master
Are you sure you want to change the base?
Add prettier #1687
Conversation
Hält sich das denn an in der .editorconfig definierten Codestyle? |
@janschoenherr From my perspective you can add the includes and tests folder also.
|
We are using it for JavaScript, JSON, etc. however we did have problems in the past with php template files (html and php in one file). I can't recall specifics though. So we might want to try those too. @hansmorb We would probably have to adjust the Regarding the git-blame ignore list. I didn't know about that :-) Seems to make sense! As you said, I would separate the actual prettier run from this PR though. I updated the PR to include |
2a3aa66
to
dbf8002
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1687 +/- ##
=========================================
Coverage 50.32% 50.32%
Complexity 2723 2723
=========================================
Files 99 99
Lines 11317 11317
=========================================
Hits 5695 5695
Misses 5622 5622 ☔ View full report in Codecov by Sentry. |
Du hast doch auch PHPStorm, entspricht dass, was Prettier aus dem Code machen will dem in der .editorconfig definierten Codestyle? Wenn ja passt das. Wenn nein müssen wir nochmal überlegen, da wir uns eigentlich geeinigt hatten uns an diesen Codestyle zu halten. |
This can be run with
npx prettier . --check
ornpx prettier . --write
It will currently only check the
./src
folder.