Vorgeschlagene Änderungen Toolchain #1435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only way to create the commonsbooking.zip Wordpress Plugin archive
locally was by calling the zipdist.sh script. Unfortunately, this script
doesn’t contain any logic on how to build the actual plugin but knows
only which directories and files to zip.
This made reliable and somewhat reproducible builds from experimental
code branches difficult.
This commit introduces a Makefile with the following targets:
* build
Builds the commonsbooking plugin archive in the local environment.
* build-in-docker
Builds the commonsbooking plugin archive in a docker container,
therefore isolating the build process.
* clean
Removes any built, generated, or downloaded files.
The targets can be called with `make TARGET_NAME`.
This should make it easy to test changes locally.
|
@kmohrf Gibt es nen Grund warum in dem Makefile so umständlich die zu inkludierenden Dateien definiert werden und nicht einfach die .distignore genommen wird? Oder noch einfacher, die bin/build-zip.sh ? |
|
Ich schließe den PR mal. Es ist nicht verloren aber bisher wurde es auch nicht gebraucht. Eigentlich haben wir alles mit wp-env organisiert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hier mal in einem PR, damit wir den Branch nicht vergessen. Beizeiten diskutieren.