Explicit declaration of properties in class that were created dynamic…

…ally. (#1607)

From PHP 8.2 it is deprecated to dynamically declare properties for objects, so declare them in class definition.

tests/php/Repository/TimeframeTest.php

@@ -18,6 +18,9 @@ class TimeframeTest extends CustomPostTypeTest {
 	protected int $timeframeDailyRepetition;
 	protected int $timeframeWeeklyRepetition;
 	protected int $timeframeManualRepetition;
+	protected int $otherItemId;
+	protected int $otherLocationId;
+	protected int $otherTimeframeId;
 
 	/**
 	 * The tests are designed in a way, that all timeframes should lie in the CURRENT_DATE plus 10 days.
@@ -482,7 +485,7 @@ public function testGetPostIdsByType_oneLocationMultiItem() {
 	 */
 	public function testGetPostIdsByType_multiLocationMultiItem() {
 		// Timeframe with enddate and one item
-		$this->timeframeId = $this->createTimeframe(
+		$timeframeId = $this->createTimeframe(
 			$this->locationId,
 			$this->itemId,
 			$this->repetition_start,

tests/php/Service/BookingRuleAppliedTest.php

@@ -14,6 +14,8 @@ class BookingRuleAppliedTest extends CustomPostTypeTest {
 	private Booking $testBookingTomorrow;
 	private int $testBookingId;
 	protected BookingRuleApplied $appliedAlwaysAllow,$appliedAlwaysDeny;
+	protected BookingRule $alwaysallow;
+	protected BookingRule $alwaysdeny;
 
 	protected function setUpTestBooking(): void {
 		$this->testBookingId       = $this->createBooking(