cleanup check_vcpkg.yaml, remove option CMAKE_BUILD_TYPE, ... #6317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpty value There is no "config" in matrix. The fixed line was introduced in 1be5a4e.
|
That's actually a copy-paste thing from the build(_vcpkg) workflow job. But yes, probably it can be removed from vcpkg update. |
+1 for having a reference. Does it make sense to move this step into a shared file called from both workflows? |
bunnybot
added
ci:success
bunnybot
added
ci:success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Enhancement of a github workflow
Issue(s) closed
Fixes -
New behavior
remove option CMAKE_BUILD_TYPE from check_vcpkg.yaml, it got an empty value
There is no "config" in matrix.
The fixed line was introduced in 1be5a4e.
Additional context
Maybe a better approach is to configure a matrix with just one value for CMAKE_BUILD_TYPE.
And add a comment above line 76 (which uses it), telling it is exactly the same as in ./build_windows*.yaml