improve build_codecheck #6315
Open
improve build_codecheck #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All files are checked anyway. Using cmake is no advantage. CodeCheck.py produces output for failures only, resulting in nicer output. This spares to install dependencies, making the run about 20sec faster.
This marks problems on github in the log and adds annotations to the lines in diff view.
bunnybot
added
ci:success
bunnybot
added
ci:success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Enhances testsuite
Issue(s) closed
Fixes -
New behavior
Do not use cmake. All files are checked anyway. Using cmake is no advantage.
CodeCheck.py produces output for failures only, resulting in nicer output.
This spares to install dependencies, making the run about 20sec faster.
Possible regressions
None I am aware of.
If
make codecheckneeds to be checked, it can be tested separately (with constructed changes).