-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding text-shadow to time/rez classes #647
base: main
Are you sure you want to change the base?
Adding text-shadow to time/rez classes #647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR 😁
I do dislike that there are times when the time & resolution are hard to see (when the background of the screenshot matches too much with the text). But I'm unsure how to best solve this problem.
I am rather against text-shadow
as it is "expensive" performance-wise. Especially if it's such a complicated text shadow.
A semi-transparent background on the text element would be much less performance-heavy - but it doesn't look very good. Adding a border-radius is also "expensive" but would likely be needed to make it look better.
I'm unsure about how to visually address the problem I've had in the app since version 1 😅
I'm open to a discussion. Feel free to share screenshots 🤝
Thank you for the screenshots and ways to address the current problem. I'm a bit busy this coming month - but I'll return to this topic when I find the time again 🤝 |
No rush. In fact I think the most proper way to solve this might be the same way you display the "total time of videos in folder" in folder view. It's a simple border radius box. While that is less 'cool' than fancy opacity/text shadows/etc it would be more in line with the existing visual language. |
Makes the time and rez metadata display exceedingly more readable.