fix(cleanup): fix cleanup for Buildah images by switching to tag-based logic #6437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksei Igrychev <[email protected]>
alexey-igrychev
force-pushed
the
fix/cleanup/support-images-built-with-buildah
branch
from
28dac2f to
d5df5a4
Compare
alexey-igrychev
changed the title
alexey-igrychev
force-pushed
the
fix/cleanup/support-images-built-with-buildah
branch
2 times, most recently
from
f8fadc3 to
8e88661
Compare
alexey-igrychev
changed the title
alexey-igrychev
changed the title
alexey-igrychev
force-pushed
the
fix/cleanup/support-images-built-with-buildah
branch
from
8e88661 to
f7503fc
Compare
…d logic The cleanup process for images built using Buildah was not working as expected due to an issue with digest-based parent lookup, as outlined in Buildah #3866. This issue occurs because Buildah currently does not provide a reliable way to retrieve the digest of an image without publishing it to a registry. To address this, the cleanup logic has been updated to use image tags instead of digests as the unique identifier for the images. This change ensures that the cleanup process works as expected, even for images built with Buildah. Signed-off-by: Aleksei Igrychev <[email protected]>
alexey-igrychev
force-pushed
the
fix/cleanup/support-images-built-with-buildah
branch
from
dc41004 to
f40381d
Compare
alexey-igrychev
deleted the
fix/cleanup/support-images-built-with-buildah
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleanup process for images built using Buildah was not working as expected due to an issue with digest-based parent lookup, as outlined in Buildah #3866. This issue occurs because Buildah currently does not provide a reliable way to retrieve the digest of an image without publishing it to a registry.
To address this, the cleanup logic has been updated to use image tags instead of digests as the unique identifier for the images. This change ensures that the cleanup process works as expected, even for images built with Buildah.
fix #6373