Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace nuxt-class-component to nuxt-property-decorator #2168

Merged
merged 3 commits into from
Apr 18, 2021
Merged

Replace nuxt-class-component to nuxt-property-decorator #2168

merged 3 commits into from
Apr 18, 2021

Conversation

dragoonzx
Copy link
Contributor

As #2110 states, nuxt-class-component is deprecated. Switching it to nuxt-property decorator seems legit.

Also, do we need vuex-class? Isn't nuxt-property-decorator enough?

sobolevn
sobolevn approved these changes Apr 18, 2021
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

This template totally need a lot more of my time 🙂

@sobolevn sobolevn merged commit 7713121 into wemake-services:master Apr 18, 2021
@sobolevn
Copy link
Member

Also, do we need vuex-class?

I think so, I haven't used latest versions of Vue and Nuxt, but back in the days vuex-class was required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragoonzx @sobolevn