Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions support #1394

Merged
merged 5 commits into from
Oct 28, 2019
Merged

Add Github Actions support #1394

merged 5 commits into from
Oct 28, 2019

Conversation

gmhabchi
Copy link
Contributor

@gmhabchi gmhabchi commented Oct 28, 2019

Add support for Github Actions and based config off of the Travis CI config 👍

ref: #1346

.github/workflows/build.yml Outdated Show resolved Hide resolved
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks almost finished. I will just ask for matrix version fix.
And we are ready to go!

@sobolevn sobolevn merged commit 8012e69 into wemake-services:master Oct 28, 2019
@sobolevn
Copy link
Member

Let's test it!

@sobolevn
Copy link
Member

sobolevn commented Oct 28, 2019

@gmhabchi looks like we have missed this step: https://github.com/wemake-services/wemake-vue-template/blob/master/.travis.yml#L33

Would you please add it?

@gmhabchi
Copy link
Contributor Author

Looks like Github Actions doesn't support env and/or .env the same way that Travis CI does. The only way I can think to fix this is to change the scripts or just move those tests into Github Actions and run directly there

@sobolevn
Copy link
Member

Ok, let's try 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants