Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split tests into internal and external #12

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Split tests into internal and external #12

merged 1 commit into from
Jun 14, 2024

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jun 13, 2024

  • external test uses only exposed API

Also

  • move library under src/ (using . is bad practice)
  • remove -fno-ignore-asserts from tests, they did nothing (this is not transitive flag)

@phadej phadej requested review from dcoutts and jorisdral as code owners June 13, 2024 12:54
jorisdral
jorisdral approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@jorisdral jorisdral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the restructuring. @dcoutts what do you think?

dcoutts
dcoutts previously requested changes Jun 14, 2024
View reviewed changes
Copy link
Member

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've no problem splitting the tests into internal and external.

Note below that -fno-ignore-asserts does have a useful (potentially) effect on the internal lib and so should be retained. Otherwise, good to go.

blockio-uring.cabal Outdated Show resolved Hide resolved
@dcoutts dcoutts dismissed their stale review June 14, 2024 11:49

Applied the suggestion.

dcoutts
dcoutts approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My trivial patch could be squashed.

@phadej @dcoutts
Split tests into internal and external
966d277 
- external test uses only exposed API

Also

- move library under src/ (using `.` is bad practice)
- remove -fno-ignore-asserts from tests, they did nothing (this is not
  transitive flag)
@dcoutts dcoutts enabled auto-merge June 14, 2024 13:25
@dcoutts dcoutts added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit 444d84d Jun 14, 2024
8 checks passed
@dcoutts dcoutts deleted the test-split branch June 14, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisdral jorisdral jorisdral approved these changes

@dcoutts dcoutts dcoutts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phadej @dcoutts @jorisdral