Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that closeIOCtx is idempotent #10

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

jorisdral
Copy link
Collaborator

@jorisdral jorisdral commented Mar 25, 2024

Also fixes a bug in io_uring_sqe_set_data, which was setting user data in an SQE if it was a CQE

@jorisdral jorisdral requested a review from dcoutts as a code owner March 25, 2024 15:05
@jorisdral jorisdral self-assigned this Mar 25, 2024
@jorisdral jorisdral marked this pull request as draft March 25, 2024 15:05
@jorisdral jorisdral force-pushed the jdral/close-idempotent-test branch 3 times, most recently from 765c3f8 to 25b8916 Compare March 25, 2024 15:34
@jorisdral jorisdral marked this pull request as ready for review March 25, 2024 15:41
@jorisdral jorisdral force-pushed the jdral/close-idempotent-test branch from 25b8916 to 2d2288a Compare March 26, 2024 13:25
Install io_uring from a package manager in GHA

Small unit tests for simple no-op submissions
Copy link
Member

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@@ -42,7 +42,7 @@ foreign import capi unsafe "liburing.h io_uring_sqe_set_data64"
#else
io_uring_sqe_set_data :: Ptr URingSQE -> CULong -> IO ()
io_uring_sqe_set_data p user_data =
do #{poke struct io_uring_cqe, user_data} p user_data
do #{poke struct io_uring_sqe, user_data} p user_data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@dcoutts dcoutts merged commit c07e1b0 into main Mar 26, 2024
8 checks passed
@dcoutts dcoutts deleted the jdral/close-idempotent-test branch March 26, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants