Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert email address obtained from LDAP to lowercase before comparin… #82

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

njpaul
Copy link

@njpaul njpaul commented May 21, 2020

  • Convert email address obtained from LDAP to lowercase before comparing it for merging with an existing account.
  • Fix a log message which discarded the second part of the message.

Resolves #81

…g it for merging with an existing account. Fix a log message which discarded the second part of the message.
@ghost
Copy link

ghost commented May 21, 2020

DeepCode's analysis on #68a9b0 found:

2 minor issues.

👉 View analysis in DeepCode’s Dashboard

☺️ If you want to provide feedback on our bot, here is how to contact us.

@xet7 xet7 merged commit e0c8156 into wekan:master Jun 26, 2024
@xet7
Copy link
Member

xet7 commented Jun 26, 2024

Well, this is merged only to old LDAP code. Newest LDAP code is here, and may have other newer changes

https://github.com/wekan/wekan/blob/main/packages/wekan-ldap/server/loginHandler.js

https://github.com/wekan/wekan/blob/main/packages/wekan-ldap/server/sync.js

I don't have LDAP server, so I can not test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing accounts cannot be merged when the email address obtained from LDAP has uppercase characters.
2 participants