Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process ICESat-2 ATL11 data up to 20210421 #295

Merged
merged 1 commit into from
Jun 26, 2021
Merged

Conversation

weiji14
Copy link
Owner

@weiji14 weiji14 commented Jun 26, 2021

From 3️⃣ to 9️⃣ ICESat-2 repeat cycles to analyze. See also previous update at #231.

ATL11.003 release is out at https://doi.org/10.5067/ATLAS/ATL11.003 which goes up to April 2021. This time, no more week-long ATL06 to ATL11 processing on our end (woohoo)! Just downloading straight from NSIDC 😁 Doing the HDF5 to Zarr conversion though, until I can be bothered with resolving #100.

@weiji14 weiji14 added enhancement ✨ New feature or request data 🗃️ Pull requests that update input datasets labels Jun 26, 2021
@weiji14 weiji14 added this to the v0.5.0 milestone Jun 26, 2021
@weiji14 weiji14 self-assigned this Jun 26, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ghost
Copy link

ghost commented Jun 26, 2021

DeepCode's analysis on #120676 found:

  • ⚠️ 1 warning 👇

Top issues

Description Example fixes
Missing close for open, add close or use a with block. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

@weiji14 weiji14 changed the title Process ATL11 Zarr data up to 20210421 Process ICESat-2 ATL11 data up to 20210421 Jun 26, 2021
Updating the ATLAS catalog to include ATL11 data up to and including 20210421, about five months of extra data over 2c755d5. Had to temporarily downgrade (locally, again) to fsspec=0.7.4 and intake-xarray=0.3.2 for the ATL11 intake download code in atl06_to_atl11.ipynb to work. Yes, taking a shortcut this time by pulling the official ATL11.003 data straight from NSIDC instead of wasting a week processing it ourselves. Glad that they have cycle 03 to cycle 09 in a single HDF5 file!!

Doing more preprocessing in the atl06_to_atl11.ipynb script by adding a set_xy_and_mask function which does lon/lat to x/y coordinate conversion and masking out of low quality data points. Should save some hassle in atl11_play.ipynb. Using 2 cores instead of 8 because of memory restrictions on the HPC cluster. So yeah, basically a quick refresh over d9ad9db.
@weiji14 weiji14 force-pushed the update/atl11_20210421 branch from 31abdb0 to 120676a Compare June 26, 2021 11:23
@sourcery-ai
Copy link

sourcery-ai bot commented Jun 26, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 2.11%.

Quality metrics Before After Change
Complexity 18.26 🙂 17.23 🙂 -1.03 👍
Method Length 257.00 ⛔ 220.25 ⛔ -36.75 👍
Working memory 15.41 ⛔ 15.26 ⛔ -0.15 👍
Quality 30.26% 😞 32.37% 😞 2.11% 👍
Other metrics Before After Change
Lines 253 282 29
Changed files Quality Before Quality After Quality Change
atl06_to_atl11.py 30.26% 😞 32.37% 😞 2.11% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data 🗃️ Pull requests that update input datasets enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant