feat: friendship source #2120
Draft
feat: friendship source #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huan
reviewed
Jan 18, 2021
| @@ -348,6 +349,10 @@ class Friendship extends EventEmitter implements Acceptable { | |||
| : FriendshipType.Unknown | |||
| } | |||
|
|
|||
| public source (): FriendshipSource | null { | |||
There was a problem hiding this comment.
This new API name looks good.
Can we also think about this API a little bit future: what if we are using a Whatsapp puppet, or a WXWork/DingTalk/Lark puppet?
Does the FriendSource return type can also fulfill those IM platform requirements?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
feature: Issues#1801 Friendship 里增加 申请好友的”来源“
ref:
wechaty-puppet Pull Request#127