-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/i18n for docs wechaty #1514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR looks promising!
Please:
- update the PR to the latest main branch and make sure it can pass the CI
- paste some screenshots in the PR description (Issue will be better) so that we can see what it looks like after it has been merged!
Head branch was pushed to by a user without write access
953759b
to
b7d62d1
Compare
This PR is ready to be reviewed. It will fullly focus on i18n part. I'll open another PR for doc update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you very much for adding the i18n solution to our docs!
copilot:all |
This PR will be good to go after the CI has turned green. Thanks! |
This CI error never occur in my local env. In local there is lots of network issue which make it hard to debug. I'll see what I can do. [ERROR] Error: request to https://cdn.jsdelivr.net/npm/wechaty-grpc@next/dist/esm/out/wechaty/puppet.swagger.json failed, reason: read ECONNRESET |
As my investigation, the CI error is the following:
Which is related to the duplicated routes, and the URL conflict problems. |
Head branch was pushed to by a user without write access
@huan I have fixed CI. This is due to the qrcode directly add route. When i18n cames in, it checks the base url.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you very much for adding i18n support to our docs website, and make the CI green!
Great! Although we have only one page with Chinese version now, i'm looking forward to translate more. |
rework doc wechaty section
add i18n support
#1512