Don't send receiver reports for SSRC during simulcast probe #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More robust when used with interceptors that modify read packets.
libwebrtc will stop sending SDES headers after the first receiver report on a SSRC. This breaks probing if the receiver report is sent before probing is completed. This change delays receiver reports for a SSRC until the first non-probe packet is received.
anders-avos
force-pushed
the
suppress-probe-receiver-reports
branch
from
dfd2697 to
ead8d6d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #623 +/- ##
=======================================
Coverage 60.63% 60.63%
=======================================
Files 471 471
Lines 48430 48465 +35
Branches 12280 12291 +11
=======================================
+ Hits 29365 29389 +24
Misses 9676 9676
- Partials 9389 9400 +11 ☔ View full report in Codecov by Sentry. |
|
Any updates on this? I'm happy to make changes if there are other ideas on how to propagate the probe status into the interceptor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libwebrtc will stop sending SDES headers after the first receiver report on an SSRC1. This breaks simulcast probing if the receiver report is sent before probing is completed. This change delays receiver reports for probing SSRCs until the first non-probe packet is received.
I didn't find any easy way to get this information into the interceptor, so I opted for using attributes. Let me know if you prefer some other means.
Footnotes
https://github.com/webrtc-sdk/webrtc/blob/0ae5688d4d490274ea47fee3f87f622ef3f13113/modules/rtp_rtcp/source/rtp_sender.cc#L509 ↩