Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure loader fills image swiper, and only display loader when replay data is nullish, not when it's loaded but there's no image data #1819

Merged
merged 1 commit into from
May 28, 2024

Conversation

emma-sg
Copy link
Member

@emma-sg emma-sg commented May 22, 2024

Closes #1818

  • Refactors image renderers, and changes the condition for which the loading indicator is displayed from "<data>.blobUrl exists and has a truthey value" to "<data> is not nullish"
  • Adds an additional class config to the shared QA loading indicator, and uses it in the image slider view to add a background and aspect ratio to the loading indicator's container so that it takes up the space it should and has an opaque background
Before After
Screenshot 2024-05-22 at 5 17 14 PM Screenshot 2024-05-22 at 5 17 31 PM

loader when replay data is nullish, not when it's loaded but there's no
image data
@emma-sg emma-sg added bug Something isn't working front end Requires front end dev work labels May 22, 2024
@emma-sg emma-sg requested a review from SuaYoo May 22, 2024 21:14
@emma-sg emma-sg self-assigned this May 22, 2024
@emma-sg emma-sg merged commit 6a94c64 into main May 28, 2024
2 checks passed
@emma-sg emma-sg deleted the frontend-improve-image-comparison-loading-indicator branch May 28, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front end Requires front end dev work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA: Screenshot view doesn't correctly handle missing images
2 participants