Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow superadmins to delete org #1788

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Conversation

SuaYoo
Copy link
Collaborator

@SuaYoo SuaYoo commented May 7, 2024

Resolves #1453

Changes

Allows superadmins to delete an org.

Manual testing

  1. Log in as superadmin
  2. Click "..." overflow action menu icon in org list.
  3. Click "Delete Org". Verify dialog is shown with the correct information and disabled submit button
  4. Enter prompt text. Verify submit button is enabled
  5. Click "Delete Org." Verify org is removed from the list

Screenshots

Page Image/video
Superadmin Dashboard Screenshot 2024-07-08 at 5 40 20 PM
Superadmin Dashboard - Delete dialog Screenshot 2024-07-08 at 5 41 45 PM

@SuaYoo SuaYoo requested a review from tw4l May 7, 2024 22:15
@SuaYoo SuaYoo force-pushed the frontend-superadmin-delete-org branch from b252d69 to ee942ae Compare May 21, 2024 23:03
@SuaYoo SuaYoo force-pushed the frontend-superadmin-delete-org branch 2 times, most recently from 04e3b2f to e7028ce Compare July 2, 2024 05:15
@SuaYoo SuaYoo changed the base branch from main to frontend-org-manage-readonly July 3, 2024 03:30
@SuaYoo SuaYoo changed the title Allow superadmins to delete org feat: Allow superadmins to delete org Jul 3, 2024
@ikreymer ikreymer marked this pull request as ready for review July 4, 2024 18:26
Base automatically changed from frontend-org-manage-readonly to main July 8, 2024 18:41
@SuaYoo SuaYoo force-pushed the frontend-superadmin-delete-org branch from 52c8422 to 5d06f9f Compare July 9, 2024 00:40
@SuaYoo SuaYoo requested review from ikreymer and Shrinks99 July 9, 2024 00:44
Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ikreymer ikreymer merged commit 020c9dc into main Jul 11, 2024
2 checks passed
@ikreymer ikreymer deleted the frontend-superadmin-delete-org branch July 11, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend implementation for deleting orgs
3 participants