Cloudflare: quote DNS TXT values

webprofusion · Nov 13, 2024 · 8322a58 · 8322a58
1 parent a2fb31e
commit 8322a58
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/src/Certify.Providers/DNS/Cloudflare/DnsProviderCloudflare.cs b/src/Certify.Providers/DNS/Cloudflare/DnsProviderCloudflare.cs
@@ -1,11 +1,12 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Net.Http;
 using System.Threading.Tasks;
 using Certify.Models.Config;
 using Certify.Models.Plugins;
 using Certify.Models.Providers;
+using Certify.Models.Shared.Validation;
 using Certify.Plugins;
 using Newtonsoft.Json;
 
@@ -203,8 +204,17 @@ private async Task<List<DnsRecordCloudflare>> GetDnsRecords(string zoneId)
             return records;
         }
 
+        private string NormalizeTXTValue(string val)
+        {
+            val = val.Trim("\"".ToCharArray());
+            val = $"\"{val}\""; // cloudflare wants TXT value to be quoted
+
+            return val;
+        }
         private async Task<ActionResult> AddDnsRecord(string zoneId, string name, string value)
         {
+            value = NormalizeTXTValue(value);
+
             var request = CreateRequest(HttpMethod.Post, string.Format(_createRecordUri, zoneId));
 
             request.Content = new StringContent(
@@ -315,6 +325,7 @@ public async Task<ActionResult> DeleteRecord(DnsRecord request)
 
         public async Task<ActionResult> DeleteRecord(DnsRecord request, bool requireSameValue)
         {
+            request.RecordValue = NormalizeTXTValue(request.RecordValue);
 
             if (string.IsNullOrEmpty(request.RecordName))
             {