DNS: Improve duplicate record handling for Route 53

webprofusion · Oct 29, 2024 · 0b2a264 · 0b2a264
1 parent 92ae0ef
commit 0b2a264
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/Certify.Providers/DNS/AWSRoute53/DnsProviderAWSRoute53.cs b/src/Certify.Providers/DNS/AWSRoute53/DnsProviderAWSRoute53.cs
@@ -168,9 +168,16 @@ public async Task<ActionResult> CreateRecord(DnsRecord request)
 
                 if (targetRecordSet != null)
                 {
-                    targetRecordSet.ResourceRecords.Add(
-                          new ResourceRecord { Value = "\"" + request.RecordValue + "\"" }
-                        );
+                    if (targetRecordSet.ResourceRecords.Any(t => t.Value == "\"" + request.RecordValue + "\""))
+                    {
+                        return new ActionResult { IsSuccess = true, Message = $"Dns Record already exists with required value. Skipping." };
+                    }
+                    else
+                    {
+                        targetRecordSet.ResourceRecords.Add(
+                              new ResourceRecord { Value = "\"" + request.RecordValue + "\"" }
+                            );
+                    }
                 }
                 else
                 {