feat: added config command #4126
Conversation
There was a problem hiding this comment.
Yes there are a lot of changes as I have completely deleted the built in commands --config and --config-name and introduced a whole new command in their place.
This is not the intend of the issue, what we want to achieve is a new --print-config/--show-config cli flag similar to other tools like jest which will output the whole webpack config on console.
|
Yes but in the issue itself you had asked to create a webpack config command which has 3 options: |
|
Hi @samrudh3125. Just a little hint from a friendly bot about the best practice when submitting pull requests:
You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR. |
No this is not the intent of the issue. Those are options for this command to print selective configurations and can be added later. |
|
Then can you please elaborate the issue once again so that I change it accordingly |
| } | ||
|
|
||
| const compiler = webpack(config.options as webpack.Configuration[]); | ||
| compiler.run((err, stats) => { |
There was a problem hiding this comment.
We don't need to run this
There was a problem hiding this comment.
No it's running only in case of --file and --name for --inckude I will remove it
| } | ||
|
|
||
| if (options.include) { | ||
| const includeOptions = webpack.config.getNormalizedWebpackOptions({}); |
There was a problem hiding this comment.
Also I think we need to apply defaults, so you will see how webpack sees your configuration
There was a problem hiding this comment.
Actually we need to comment the default values beside them which is getting very complex so shall I apply the defaults?
There was a problem hiding this comment.
You can get default value applyWebpackOptionsBaseDefaults and applyWebpackOptionsDefaults from:
const {
applyWebpackOptionsDefaults,
applyWebpackOptionsBaseDefaults
} = require("webpack/config/defaults");
How I see this logic, you load config file/files, normalize and them apply default.
Also we have two possible commands:
webpack configjust print full resolved configuration, i.e. after apply normalization and defaultwebpack config --diffshow only options which are different after normalize and default, so you can undestand which options you don't need because they are default
|
My bad actually since I removed the command I deleted the tests |
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@samrudh3125 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @alexander-akait Please review the new changes. |
What kind of change does this PR introduce?
It introduces a new feature which is the config command which has three options i.e file, name and include.
Did you add tests for your changes?
I have added tests for name and file option but for include didn't add tests as at this stage it just prints the present configuration in the console.
Summary
The issue #3537 is solved in this PR. This was a very good issue to work on as i could understand the complete codebase of webpack as I am aiming at working in one of the projects of webpack in GSOC.
Does this PR introduce a breaking change?
Yes there are a lot of changes as I have completely deleted the built in commands --config and --config-name and introduced a whole new command in their place.
Other information