This repository has been archived by the owner on Jul 18, 2019. It is now read-only.
fix(security): update dependencies #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling of paths in `loader` needs to be changed as with the new version of `rcloader` returned objects are unconditionally merged into new objects.
|
|
|
This looks like it should be good to merge. Any reason why there is a 6 month delay? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Currently there are several warnings for outdated libraries. These block further changes. See https://david-dm.org/webpack-contrib/jshint-loader
Breaking Changes
No breaking changes.
Additional Info
Unfortunately the handling of paths had to be changed, as the updated version of
rcloaderhandles merging differently and would return objects containing the characters of the path otherwise ({ '0': 't', '1': 'e', '2': 's', '3': 't', '4': '/', '5': 'f', '6': 'i', '7': 'x', '8': 't', '9': 'u', '10': 'r', '11': 'e', '12': 's', '13': '/', ... }).