-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: resolve issue #1028: optimising naming for best compression #1062
Conversation
have some bugs from master :/ |
We use a similar technique, but just defining a custom |
Css-loader get async files and parse, it is allways randomized work. Class save classnames positions for every file (a,b,c,...). As a file-path, it is always stable content hash for project. It is cache frendly. |
Codecov Report
@@ Coverage Diff @@
## master #1062 +/- ##
==========================================
- Coverage 97.17% 96.86% -0.32%
==========================================
Files 10 11 +1
Lines 460 542 +82
Branches 153 176 +23
==========================================
+ Hits 447 525 +78
- Misses 12 16 +4
Partials 1 1
Continue to review full report at Codecov.
|
and https://gist.github.com/denisx/9dc0e8c542b810e67f41691c89e7b948 for check hash length |
Denis 🎃 Khripkov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Add css hash len suggest - we have full hash map after css-1-letter running. |
This PR contains a:
Motivation / Use-Case
resolve issue #1028
For efficient gzip/br compression, plugin combine css hash via one symbol name,
as a classname position at file, with filepath
hash:base64:8
, to have strong sequences.