Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add a check to skip comment when manually triggering workflow on a branch #4357

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

fix: add a check to skip comment when manually triggering workflow on a branch #4357

wants to merge 5 commits into from

Commits on Oct 22, 2024

  1. feat: added a workflow to preview Storybook using Chromatic 

    Developers can trigger this workflow by commenting /storybook on pull requests
or by manually running it for a specific branch via the GitHub Actions tab.
    @swapnilmmane
    swapnilmmane committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ac50d04 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. chore: removed unused postinstall step from workflow

    @swapnilmmane
    swapnilmmane committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a99ca7b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin' into storybook-chromatic-workflow

    @swapnilmmane
    swapnilmmane committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3e30c3a View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Merge remote-tracking branch 'origin' into storybook-chromatic-workflow

    @swapnilmmane
    swapnilmmane committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4d19843 View commit details
    Browse the repository at this point in the history

  2. fix: add a check to skip comment when manually triggering workflow on… 

    … a branch

During manual (workflow_dispatch) runs on a branch, there was no pull request,
but the comment step looked for a pull request number.
This change skips the comment step for manual triggers when no PR is available.
    @swapnilmmane
    swapnilmmane committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    2df428d View commit details
    Browse the repository at this point in the history