fix(api-headless-cms-bulk-actions): empty trash bin processing entries in series #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/api-headless-cms-bulk-actions/src/tasks/createEmptyTrashBinsTask.ts # packages/api-headless-cms-bulk-actions/src/types.ts
leopuleo
changed the title
brunozoric
requested changes
Oct 29, 2024
| @@ -10,7 +10,10 @@ export interface CreateBulkActionGraphQL { | |||
|
|
|||
| export const createBulkActionGraphQL = (config: CreateBulkActionGraphQL) => { | |||
| return new ContextPlugin<HcmsBulkActionsContext>(async context => { | |||
| if (!(await isHeadlessCmsReady(context))) { | |||
There was a problem hiding this comment.
isHeadlessCmsReady() already has checks for tenant and locale.
| const tenant = context.tenancy.getCurrentTenant(); | ||
| const locale = context.i18n.getContentLocale(); | ||
|
|
||
| if (!tenant || !locale || !(await isHeadlessCmsReady(context))) { |
There was a problem hiding this comment.
Same as in createBulkActionGraphQL file.
| return; | ||
| } | ||
|
|
||
| const plugin = new CmsGraphQLSchemaPlugin<Context>({ | ||
| typeDefs: createTypeDefs(models as NonEmptyArray<CmsModel>), | ||
| resolvers: createResolvers(models as NonEmptyArray<CmsModel>) | ||
| resolvers: createResolvers(models as NonEmptyArray<CmsModel>), | ||
| isApplicable: context => |
There was a problem hiding this comment.
I dont understand this check. You get tenant on line 10 and then you get it here again, with same method. Isn't it the same?
brunozoric
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR addresses a bug that arose when emptying the trash bin for instances with many tenants.
Previously, the deletion process operated in parallel. Each tenant, locale, or model triggered a subtask to delete all eligible entries in the specific model for removal. This approach caused errors when dealing with instances that had multiple tenants.
With this update, we consolidate the deletion into a single task that iterates through all tenants, locales, and models, deleting the eligible entries in series.
How Has This Been Tested?
Manually