Warn when HDR canvas is not supported #451
Conversation
beaufortfrancois
force-pushed
the
get-configuration
branch
from
a5be0dc
to
7606281
Compare
sample/particles/main.ts
Outdated
| } | ||
| if ( | ||
| simulationParams.toneMappingMode === 'extended' && | ||
| context.getConfiguration().toneMapping.mode !== 'extended' |
There was a problem hiding this comment.
I believe this is necessary for this to work on browsers that don't expose toneMapping (though unfortunately the rest of the sample doesn't work right now in Firefox so I can't check)
| context.getConfiguration().toneMapping.mode !== 'extended' | |
| context.getConfiguration().toneMapping?.mode !== 'extended' |
There was a problem hiding this comment.
(actually now that I think about it that wouldn't trigger it either because firefox probably doesn't have getConfiguration or toneMapping.)
This logic will be triggered if WebKit chooses to remove this temporarily until they implement HDR canvas. (The sample doesn't display as HDR right now in Safari TP even though the option exists so I'm assuming it's not implemented.) @mwyrzykowski
There was a problem hiding this comment.
That's right, the WebKit PR just added the options to the idl file.
HDR Canvas is tracked by https://bugs.webkit.org/show_bug.cgi?id=276502
Following up on #432 (comment), this PR adds a warning when the browser does not support HDR canvas thanks to the new GPUCanvasContext
getConfiguration()method added to spec.