Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update samples to work with TypeScript strict mode (part 1) #278

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Update samples to work with TypeScript strict mode (part 1) #278

merged 4 commits into from
Jul 20, 2023

Conversation

nash1111
Copy link
Contributor

Like this, I want to add types to all samples to enhance safety. If there are no issues, I would like to proceed with adding them to all.

@nash1111 nash1111 changed the title WIP: strict trus WIP: compilerOption strict true Jun 17, 2023
@kainino0x kainino0x self-requested a review June 23, 2023 21:47
kainino0x
kainino0x reviewed Jun 23, 2023
View reviewed changes
src/sample/animometer/main.ts Outdated Show resolved Hide resolved
src/components/SampleLayout.tsx Show resolved Hide resolved
src/sample/animometer/main.ts Outdated Show resolved Hide resolved
@kainino0x
Copy link
Collaborator

Looking good so far, hopefully the suggestions will make updating the rest of the samples a bit easier - ping me when you need another review!

@kainino0x
Copy link
Collaborator

And do be sure to pull the branch before you continue, because I committed suggestions to it.

@nash1111
Copy link
Contributor Author

Thank you for the review! I just did a git pull for your changes. Once I've corrected all the examples, I'll request a re-review from you!

@kainino0x
Copy link
Collaborator

Hi @nash1111, will you still be able to complete this PR? If not, someone else can pick it up (eventually)!

@kainino0x kainino0x mentioned this pull request Jul 19, 2023
Closed
@nash1111
Copy link
Contributor Author

I am capable of handling it, but given the volume, I'm considering splitting it into two PRs. The first PR will modify only the files that have been completed so far with strict: false, and the second will edit the remaining files to make the entire project strict: true. I believe that smaller PRs are preferable, so I'll be aiming for that. This PR is the first one.
I will submit the second PR by the end of this month.

@nash1111 nash1111 requested a review from kainino0x July 20, 2023 13:02
@nash1111 nash1111 marked this pull request as ready for review July 20, 2023 13:02
@kainino0x kainino0x changed the title WIP: compilerOption strict true Update samples to work with TypeScript strict mode (part 1) Jul 20, 2023
kainino0x
kainino0x approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! LGTM

@kainino0x kainino0x enabled auto-merge (squash) July 20, 2023 20:43
@kainino0x kainino0x merged commit 5b0d24c into webgpu:main Jul 20, 2023
1 check passed
@nash1111 nash1111 mentioned this pull request Jul 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kainino0x kainino0x kainino0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nash1111 @kainino0x